Github user srowen commented on a diff in the pull request:
https://github.com/apache/incubator-spark/pull/570#discussion_r9976665
--- Diff: project/SparkBuild.scala ---
@@ -236,13 +236,15 @@ object SparkBuild extends Build {
publishLocalBoth <<= Seq(publishLocal in MavenCompile,
publishLocal).dependOn
) ++ net.virtualvoid.sbt.graph.Plugin.graphSettings ++ ScalaStyleSettings
- val slf4jVersion = "1.7.2"
+ val slf4jVersion = "1.7.5"
val excludeCglib = ExclusionRule(organization =
"org.sonatype.sisu.inject")
val excludeJackson = ExclusionRule(organization = "org.codehaus.jackson")
val excludeNetty = ExclusionRule(organization = "org.jboss.netty")
val excludeAsm = ExclusionRule(organization = "asm")
val excludeSnappy = ExclusionRule(organization = "org.xerial.snappy")
+ val excludeCommonsLogging = ExclusionRule(organization =
"commons-logging")
+ val excludeSLF4J = ExclusionRule(organization = "org.slf4j")
--- End diff --
@pwendell What I see left are dependencies from third-party libraries on
slf4j-api, which is fine. Most depend on 1.7.5 (so good that the version in
Spark is bumped to 1.7.5), and a few use 1.6.x, which should be entirely
compatible. It's also OK for dependencies to have slf4j-over-log4j12. So AFAICT
it's fine in this regard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
