Github user pwendell commented on the pull request:
https://github.com/apache/incubator-spark/pull/570#issuecomment-35821527
hey @srowen this is looking good. My main observation was I think we should
add the slf4j-log4j bridge as a compile dependency in core in the maven build
and then remove it from all the modules. Don't know why that's different than
the current sbt build - I think we never noticed because it ends up getting
bundled anyways since some of the sub modules include it.
I also added instructions for generating the dependency graph in both
builds on the wiki:
https://cwiki.apache.org/confluence/display/SPARK/Useful+Developer+Tools
It might be useful for you when auditing the effects of these changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
[email protected] or file a JIRA ticket with INFRA.
---
