-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12032/
-----------------------------------------------------------
(Updated July 11, 2013, 7:13 p.m.)
Review request for Sqoop.
Changes
-------
Removed manager.getLastModifiedCheckColumnType() as per review comment.
Bugs: SQOOP-906
https://issues.apache.org/jira/browse/SQOOP-906
Repository: sqoop-trunk
Description
-------
Incremental import using lastmodified mode always assumes column type to be
TIMESTAMP which is causing issues with Oracle Connector. This patch fixes that.
Diffs (updated)
-----
src/java/org/apache/sqoop/manager/ConnManager.java c84c859
src/java/org/apache/sqoop/manager/OracleManager.java 686bc19
src/java/org/apache/sqoop/tool/ImportTool.java cb800b6
src/test/com/cloudera/sqoop/TestIncrementalImport.java 02080df
src/test/com/cloudera/sqoop/TestMerge.java 5010cf2
src/test/com/cloudera/sqoop/ThirdPartyTests.java ada5c72
src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 877d7f8
src/test/org/apache/sqoop/manager/oracle/OracleIncrementalImportTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/12032/diff/
Testing
-------
Unit tests & oracle third party tests are passing. Also tested manually.
Thanks,
Raghav Gautam
