-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12451/
-----------------------------------------------------------

(Updated July 12, 2013, 11:12 p.m.)


Review request for Sqoop and Jarek Cecho.


Changes
-------

Add test case.


Bugs: SQOOP-1049
    https://issues.apache.org/jira/browse/SQOOP-1049


Repository: sqoop-sqoop2


Description (updated)
-------

commit 40709543f87c4a6f8fc6e8d7ad124cb4e917185d
Author: Mengwei Ding <[email protected]>
Date:   Wed Jul 10 11:41:05 2013 -0700

    SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

:100644 100644 abcc89d... eb9f3d2... M  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
:100644 100644 96818ba... 86a3f8a... M  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
:100644 100644 7792c57... 8f006ab... M  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
:100644 100644 ef27236... e114df4... M  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
:100644 100644 44fc984... 0f45090... M  
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
:100644 100644 7ecc900... 30ae4f0... M  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java


Diffs (updated)
-----

  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
 abcc89d 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
 96818ba 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
 7792c57 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
 ef27236 
  
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
 44fc984 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
 7ecc900 

Diff: https://reviews.apache.org/r/12451/diff/


Testing
-------

Have done a manual test, in which I successfully import a table with some null 
values in partition column.


Thanks,

Mengwei Ding

Reply via email to