-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12451/
-----------------------------------------------------------

(Updated July 18, 2013, 8:50 p.m.)


Review request for Sqoop and Jarek Cecho.


Changes
-------

remove PartitionNull option in the context, because it could directly be fetch 
via JobConfig.


Bugs: SQOOP-1049
    https://issues.apache.org/jira/browse/SQOOP-1049


Repository: sqoop-sqoop2


Description (updated)
-------

commit c41d3e475700c4d2f97606b153d75a86ef543cf4
Author: Mengwei Ding <[email protected]>
Date:   Wed Jul 10 11:41:05 2013 -0700

    SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

:100644 100644 f3dee8e... 27db8af... M  
common/src/main/java/org/apache/sqoop/model/FormUtils.java
:100644 100644 7792c57... 8d0c4ab... M  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
:100644 100644 ef27236... 0991b28... M  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
:100644 100644 44fc984... 0950e32... M  
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
:100644 100644 7ecc900... a33dd6c... M  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java


Diffs (updated)
-----

  common/src/main/java/org/apache/sqoop/model/FormUtils.java f3dee8e 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
 7792c57 
  
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
 ef27236 
  
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
 44fc984 
  
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
 7ecc900 

Diff: https://reviews.apache.org/r/12451/diff/


Testing
-------

Have done a manual test, in which I successfully import a table with some null 
values in partition column.


Thanks,

Mengwei Ding

Reply via email to