----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28110/#review61699 -----------------------------------------------------------
common/src/main/java/org/apache/sqoop/schema/type/Enum.java <https://reviews.apache.org/r/28110/#comment103510> NITS: I'd always use brackets just to be safe. Sometimes after merge or rebase, code will be broken. The famous SSL heartbleeding is a lesson for us all to learn. - Qian Xu On Nov. 17, 2014, 8:48 a.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28110/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 8:48 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1716 > https://issues.apache.org/jira/browse/SQOOP-1716 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > dec8c0e > common/src/main/java/org/apache/sqoop/schema/type/Enum.java 1388d49 > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > 9f8ee3e > > Diff: https://reviews.apache.org/r/28110/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
