> On Nov. 18, 2014, 12:58 p.m., Abraham Elmahrek wrote: > > common/src/main/java/org/apache/sqoop/schema/type/Enum.java, line 77 > > <https://reviews.apache.org/r/28110/diff/3/?file=767562#file767562line77> > > > > Add tests for validate new logic? > > Veena Basavaraj wrote: > testing equals? we dont have one for any of the types. Does it make sense > to create a ticket to add it for all of the column types? > > Abraham Elmahrek wrote: > I don't see why not. > > Veena Basavaraj wrote: > i have added a ticket for the other types
https://issues.apache.org/jira/browse/SQOOP-1761 - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28110/#review62002 ----------------------------------------------------------- On Nov. 18, 2014, 2:49 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28110/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 2:49 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1716 > https://issues.apache.org/jira/browse/SQOOP-1716 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/util/SchemaSerialization.java > dec8c0e > common/src/main/java/org/apache/sqoop/schema/type/Enum.java 1388d49 > > common/src/test/java/org/apache/sqoop/json/util/TestSchemaSerialization.java > 9f8ee3e > common/src/test/java/org/apache/sqoop/schema/type/TestEnum.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/28110/diff/ > > > Testing > ------- > > > Thanks, > > Veena Basavaraj > >
