----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28927/#review64834 -----------------------------------------------------------
Ship it! Very well done. a few things we should also mention docs/src/site/sphinx/Connectors.rst <https://reviews.apache.org/r/28927/#comment107621> nice, to have the optional/ required documented. docs/src/site/sphinx/Connectors.rst <https://reviews.apache.org/r/28927/#comment107622> also worth adding details 1. on the IDF it uses. 2. on how it needs ot adhere to the IDF formats in both extractor and loader docs/src/site/sphinx/Connectors.rst <https://reviews.apache.org/r/28927/#comment107623> not sure it is worht replicating the usage here, add a link to the command line doc, since it becomes really hard to change every place when we change one thing in the job api - Veena Basavaraj On Dec. 10, 2014, 8:15 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28927/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2014, 8:15 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1757 > https://issues.apache.org/jira/browse/SQOOP-1757 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 1fc9619096e1cc37bac6d1abc7a9b9933855111e > Author: Abraham Elmahrek <[email protected]> > Date: Wed Dec 10 17:56:15 2014 -0600 > > SQOOP-1756: Sqoop2: Specific connector documentation > > :000000 100644 0000000... 79a74f5... A docs/src/site/sphinx/Connectors.rst > > > Diffs > ----- > > docs/src/site/sphinx/Connectors.rst PRE-CREATION > docs/src/site/sphinx/index.rst 8257858 > > Diff: https://reviews.apache.org/r/28927/diff/ > > > Testing > ------- > > mvn site -pl docs > > > Thanks, > > Abraham Elmahrek > >
