----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28927/#review64973 -----------------------------------------------------------
Ship it! Just one small nit that I've noticed, otherwise good to go! docs/src/site/sphinx/Connectors.rst <https://reviews.apache.org/r/28927/#comment107809> Technically speaking username/password are not required. We don't have validations for those at [1] and some databaes (like the mysql) does allow anonymous access. Links: 1: https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java#L44 Jarcec - Jarek Cecho On Dec. 12, 2014, 3:29 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28927/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2014, 3:29 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1757 > https://issues.apache.org/jira/browse/SQOOP-1757 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 1fc9619096e1cc37bac6d1abc7a9b9933855111e > Author: Abraham Elmahrek <[email protected]> > Date: Wed Dec 10 17:56:15 2014 -0600 > > SQOOP-1756: Sqoop2: Specific connector documentation > > :000000 100644 0000000... 79a74f5... A docs/src/site/sphinx/Connectors.rst > > > Diffs > ----- > > docs/src/site/sphinx/Connectors.rst PRE-CREATION > docs/src/site/sphinx/index.rst 8257858 > > Diff: https://reviews.apache.org/r/28927/diff/ > > > Testing > ------- > > mvn site -pl docs > > > Thanks, > > Abraham Elmahrek > >
