----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33308/#review80856 -----------------------------------------------------------
Thank you for finding the issue Keegan. I have one question: src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java <https://reviews.apache.org/r/33308/#comment130980> After reading the linked documentation (referenced on the JIRA) [1] it seems to me that the proper place where to put the table hints is on this line in form of "INTO table WITH $TABLE_HINTS AS x", right? Links: 1: https://msdn.microsoft.com/en-us/library/bb510625.aspx Jarcec - Jarek Cecho On April 17, 2015, 2:11 p.m., Keegan Witt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33308/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 2:11 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-2296 1st patch > > > Diffs > ----- > > > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java > 0cb2c78 > > src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java > a144e30 > > Diff: https://reviews.apache.org/r/33308/diff/ > > > Testing > ------- > > > Thanks, > > Keegan Witt > >
