> On April 20, 2015, 7:15 p.m., Jarek Cecho wrote: > > src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java, > > lines 86-87 > > <https://reviews.apache.org/r/33308/diff/1/?file=933806#file933806line86> > > > > After reading the linked documentation (referenced on the JIRA) [1] it > > seems to me that the proper place where to put the table hints is on this > > line in form of "INTO table WITH $TABLE_HINTS AS x", right? > > > > Links: > > 1: https://msdn.microsoft.com/en-us/library/bb510625.aspx
My understanding (and I'm not a SQL Server expert) is that those table hints only apply if you are merging FROM another table. However, one hint that would apply is the "WITH <merge_hint>", but that doesn't support the entire table hint vocabulary. Since the argument we currently have for table hints might contain NOLOCK or READUNCOMMITTED (which are unsupported) I felt to be safe, we would need a separate argument to support that. Should I open a separate Jira for that? - Keegan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33308/#review80856 ----------------------------------------------------------- On April 17, 2015, 10:11 a.m., Keegan Witt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33308/ > ----------------------------------------------------------- > > (Updated April 17, 2015, 10:11 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-2296 1st patch > > > Diffs > ----- > > > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormat.java > 0cb2c78 > > src/test/org/apache/sqoop/mapreduce/sqlserver/SqlServerUpsertOutputFormatTest.java > a144e30 > > Diff: https://reviews.apache.org/r/33308/diff/ > > > Testing > ------- > > > Thanks, > > Keegan Witt > >
