----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40216/#review106316 -----------------------------------------------------------
Thank you for the work here Colin! I have couple of high level comments: 1) It seems that we have many dimensions that we want to try. Rather then using the generic methods, can we make the test parametrized in the same way we have other similar tests? Look at PartitionerTest as an example [1]. 2) Since now there is not "backup" solution in case of id, can we be more exhasive in the tests? Let's try all create/update/delete/read on jobs/links and start/stop/status on submissions. Links: 1: https://github.com/apache/sqoop/blob/sqoop2/test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java - Jarek Cecho On Nov. 12, 2015, 6:27 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40216/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 6:27 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Add test cases for the object name with special char, eg, "." , "/", "?", "&" > etc. > > > Diffs > ----- > > > test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java > 811315a > > Diff: https://reviews.apache.org/r/40216/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
