> On Dec. 5, 2015, 2:28 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java, > > lines 166-168 > > <https://reviews.apache.org/r/40895/diff/4/?file=1153630#file1153630line166> > > > > I'm generally +1 on migrating to the MiniClusterFactory to be honest, > > but let's make that as standalone patch - very likely a subtask of > > SQOOP-2329. > > Abraham Fine wrote: > so we already use the SqoopMiniClusterFactory in the > SqoopInfrastructureProvider. I really do not see an easy way to run the > JettyTestCase tests on a real cluster without it. is this change really > worthy of its own jira?
My apologies, I've confused this with one the SqoopTestCase inheritence changes that we're making as part of SQOOP-2329. We're just using the factory here, so not a concern. > On Dec. 5, 2015, 2:28 p.m., Jarek Cecho wrote: > > pom.xml, lines 233-259 > > <https://reviews.apache.org/r/40895/diff/4/?file=1153628#file1153628line233> > > > > I'm not a big fan of the current approach of using maven profiles for > > all the various groups we have - it's hard to mantain and get oriented in. > > Would it make sense to simply document how to specify the given groups on > > command line or is that too hard to do? > > Abraham Fine wrote: > i am sure that is something that maven supports. it just seemed to me > that this seemed like a perfect use case for a profile. i think we only have > two groups at the moment so i can not really see this getting out of hand any > time soon. Yup we have only two because I've cleaned them up in the past :) Let's add the new profile now and we'll clean it up if it gets out of hand again. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40895/#review109085 ----------------------------------------------------------- On Dec. 4, 2015, 7:46 a.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40895/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 7:46 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2720 > https://issues.apache.org/jira/browse/SQOOP-2720 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Allow the integration tests to be run against a real cluster > > > Diffs > ----- > > pom.xml 91721ce > test/src/main/java/org/apache/sqoop/test/minicluster/RealSqoopCluster.java > 325a6a9 > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > bd4ba6a > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > 0e46bf3 > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java > aa062fb > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > 6e78a13 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > 6228b0d > > test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java > 4a2e7a4 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java > 8d02e24 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java > b88940a > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_5UpgradeTest.java > 1f3563d > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_6UpgradeTest.java > a57a420 > > test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java > cbf1e90 > > Diff: https://reviews.apache.org/r/40895/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
