> On Dec. 5, 2015, 2:28 p.m., Jarek Cecho wrote: > > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java, > > lines 107-111 > > <https://reviews.apache.org/r/40895/diff/4/?file=1153630#file1153630line107> > > > > Let's keep the "setMethodName" and create new BeforeMethod call to drop > > the getMapreduceDirectory()? > > Abraham Fine wrote: > my concern here is that getMapreduceDirectory is dependent on having the > name set. so, considering these two methods seem to always be called > together, i would rather not create the opportunity to have a bug in > beforemethod order. > > Abraham Fine wrote: > discussed with jarcec offline, we agreed that ordering beforemethod calls > would be overkill here.
Yup, in this simple case, I'm fine with this single callback. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40895/#review109085 ----------------------------------------------------------- On Dec. 7, 2015, 10:57 p.m., Abraham Fine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40895/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 10:57 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2720 > https://issues.apache.org/jira/browse/SQOOP-2720 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Sqoop2: Allow the integration tests to be run against a real cluster > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9b9359b > pom.xml 91721ce > test/src/main/java/org/apache/sqoop/test/minicluster/RealSqoopCluster.java > 325a6a9 > test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java > e78adc0 > > test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java > 0e46bf3 > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromHDFSToKafkaTest.java > aa062fb > > test/src/test/java/org/apache/sqoop/integration/connector/kafka/FromRDBMSToKafkaTest.java > 6e78a13 > > test/src/test/java/org/apache/sqoop/integration/connectorloading/BlacklistedConnectorTest.java > 6228b0d > > test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java > 4a2e7a4 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java > 8d02e24 > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_4UpgradeTest.java > b88940a > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_5UpgradeTest.java > 1f3563d > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_6UpgradeTest.java > a57a420 > > Diff: https://reviews.apache.org/r/40895/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Abraham Fine > >
