> On Dec. 13, 2016, 3:27 p.m., Szabolcs Vasas wrote: > > src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java, line 81 > > <https://reviews.apache.org/r/54699/diff/1/?file=1582741#file1582741line81> > > > > Is the tableName already escaped or shall we invoke > > OracleUtils.escapeIdentifier on it?
The tableName is already invoked, however you're right: this should be consistent throught this patch, I'll remove it from the columns too, as they are escaped already as well - there should probably be a central logic for this, as right now the escaping logic is all over the code... - Anna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54699/#review159010 ----------------------------------------------------------- On Dec. 13, 2016, 2:29 p.m., Anna Szonyi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54699/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 2:29 p.m.) > > > Review request for Sqoop, Attila Szabo and Szabolcs Vasas. > > > Bugs: SQOOP-3081 > https://issues.apache.org/jira/browse/SQOOP-3081 > > > Repository: sqoop-trunk > > > Description > ------- > > SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In > OracleUpsertOutputFormat to make it consistent with the rest of the code and > add escaping to the rest of the column variables. > > > Diffs > ----- > > src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 > > Diff: https://reviews.apache.org/r/54699/diff/ > > > Testing > ------- > > ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib > -Dthirdparty=true > -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" > -Dtest.timeout=1000000 -Dtestcase=*racle*Test with special attention to > OracleExportTest#testUpsertTextExport > > > Thanks, > > Anna Szonyi > >
