-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54699/#review159422
-----------------------------------------------------------


Ship it!




Ship It!

- Boglarka Egyed


On Dec. 14, 2016, 11:50 a.m., Anna Szonyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54699/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2016, 11:50 a.m.)
> 
> 
> Review request for Sqoop, Attila Szabo and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3081
>     https://issues.apache.org/jira/browse/SQOOP-3081
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3081 Introduce OracleEscapeUtils.escapeIdentifiers In 
> OracleUpsertOutputFormat to make it consistent with the rest of the code and 
> add escaping to the rest of the column variables.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/OracleUpsertOutputFormat.java 88754e7 
>   src/test/com/cloudera/sqoop/manager/OracleExportTest.java 382eb92 
> 
> Diff: https://reviews.apache.org/r/54699/diff/
> 
> 
> Testing
> -------
> 
> ran ant clean test, ant clean test -Dsqoop.thirdparty.lib.dir=$3rdpartylib 
> -Dthirdparty=true 
> -Dsqoop.test.oracle.connectstring=$connstr-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom"
>  -Dtest.timeout=1000000 -Dtestcase=*racle*Test with special attention to 
> OracleExportTest#testUpsertTextExport
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>

Reply via email to