Hi Priyanshi, I am happy that you would like to contribute! There is a wiki page ( https://cwiki.apache.org/confluence/display/SQOOP/How+to+Contribute) about how you can start working on Sqoop I think reading it is a good first step. If you have any further questions you can always contact the dev list.
Regards, Szabolcs On Mon, Jul 31, 2017 at 6:14 PM, Priyanshi Sharma < priyanshisharma1...@gmail.com> wrote: > Hey everyone, > I'm Priyanshi Sharma. > 3rd year B.tech student studying Computer Science. > I'd like to contribute. > Can someone please help me get started? > > > On Fri, Jul 28, 2017 at 7:41 PM, szvasas <g...@git.apache.org> wrote: > > > Github user szvasas commented on a diff in the pull request: > > > > https://github.com/apache/sqoop/pull/38#discussion_r130098876 > > > > --- Diff: src/test/com/cloudera/sqoop/JobToolTest.java --- > > @@ -0,0 +1,258 @@ > > +/** > > + * Licensed to the Apache Software Foundation (ASF) under one > > + * or more contributor license agreements. See the NOTICE file > > + * distributed with this work for additional information > > + * regarding copyright ownership. The ASF licenses this file > > + * to you under the Apache License, Version 2.0 (the > > + * "License"); you may not use this file except in compliance > > + * with the License. You may obtain a copy of the License at > > + * > > + * http://www.apache.org/licenses/LICENSE-2.0 > > + * > > + * Unless required by applicable law or agreed to in writing, > software > > + * distributed under the License is distributed on an "AS IS" BASIS, > > + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > > implied. > > + * See the License for the specific language governing permissions > and > > + * limitations under the License. > > + */ > > + > > +package com.cloudera.sqoop; > > + > > +import com.cloudera.sqoop.manager.MySQLTestUtils; > > +import com.cloudera.sqoop.manager.OracleUtils; > > +import com.cloudera.sqoop.testutil.BaseSqoopTestCase; > > +import com.cloudera.sqoop.testutil.CommonArgs; > > +import org.apache.commons.logging.Log; > > +import org.apache.commons.logging.LogFactory; > > +import org.apache.hadoop.conf.Configuration; > > +import org.apache.sqoop.Sqoop; > > +import org.apache.sqoop.manager.ConnManager; > > +import org.apache.sqoop.manager.DefaultManagerFactory; > > +import org.apache.sqoop.manager.sqlserver.MSSQLTestUtils; > > +import org.apache.sqoop.tool.JobTool; > > +import org.junit.After; > > +import org.junit.Before; > > +import org.junit.Test; > > +import org.junit.runner.RunWith; > > +import org.junit.runners.Parameterized; > > + > > +import java.io.IOException; > > +import java.sql.Connection; > > +import java.sql.SQLException; > > +import java.sql.Statement; > > +import java.util.ArrayList; > > +import java.util.Arrays; > > + > > +import static org.junit.Assert.assertEquals; > > + > > +@RunWith(Parameterized.class) > > +public class JobToolTest extends BaseSqoopTestCase { > > + > > + public static final Log LOG = LogFactory > > + .getLog(MetaConnectIncrementalImportTe > > st.class.getName()); > > + > > + private static MySQLTestUtils mySQLTestUtils = new > > MySQLTestUtils(); > > + private static MSSQLTestUtils msSQLTestUtils = new > > MSSQLTestUtils(); > > + ConnManager cm; > > + > > + @Parameterized.Parameters(name = "metaConnectString = {0}, > > metaUser = {1}, metaPassword = {2}") > > + public static Iterable<? extends Object> dbConnectParameters() { > > + return Arrays.asList( > > + new Object[] { > > + mySQLTestUtils.getHostUrl(), > > mySQLTestUtils.getUserName(), > > + mySQLTestUtils.getUserPass() > > + }, > > + new Object[] { > > + OracleUtils.CONNECT_STRING, > > OracleUtils.ORACLE_USER_NAME, > > + OracleUtils.ORACLE_USER_PASS > > + }, > > + new Object[] { > > + msSQLTestUtils.getDBConnectString(), > > msSQLTestUtils.getDBUserName(), > > + msSQLTestUtils.getDBPassWord() > > + }, > > + new Object[] { > > + System.getProperty( > > + "sqoop.test.postgresql. > > connectstring.host_url", > > + "jdbc:postgresql://localhost/"), > > + System.getProperty( > > + "sqoop.test.postgresql. > > connectstring.username", > > + "sqooptest"), > > + System.getProperty( > > + "sqoop.test.postgresql. > > connectstring.password"), > > + }, > > + new Object[] { > > + System.getProperty( > > + "sqoop.test.db2.connectstring. > > host_url", > > + "jdbc:db2://db2host:50000"), > > + System.getProperty( > > + "sqoop.test.db2.connectstring. > > username", > > + "SQOOP"), > > + System.getProperty( > > + "sqoop.test.db2.connectstring. > > password", > > + "SQOOP"), > > + }, > > + new Object[] { "jdbc:hsqldb:mem:sqoopmetastore", > > "SA" , "" } > > + ); > > + } > > + > > + @Before > > + public void setUp() { > > + super.setUp(); > > + > > + SqoopOptions options = getSqoopOptions(); > > + > > + Connection conn = getConnection(options); > > + > > + try { > > + Statement statement = conn.createStatement(); > > + statement.execute("DROP TABLE SQOOP_ROOT"); > > + statement.execute("DROP TABLE SQOOP_SESSIONS"); > > + conn.commit(); > > + } catch (Exception e) { > > + LOG.error("Failed to clear metastore database"); > > + } > > + //Methods from BaseSqoopTestClass reference the test Hsqldb > > database, not the metastore > > + try{ > > + dropTableIfExists("CarLocations"); > > + } catch (SQLException e) { > > + LOG.error("Failed to drop table CarLocations"); > > + } > > + setCurTableName("CarLocations"); > > + createTableWithColTypesAndNames( > > + new String [] {"carId", "Locations"}, > > + new String [] {"INTEGER", "VARCHAR"}, > > + new String [] {"1", "'Lexus'"}); > > + } > > + > > + private Connection getConnection(SqoopOptions options) { > > + try { > > + com.cloudera.sqoop.metastore.JobData jd = new > > com.cloudera.sqoop.metastore.JobData(options, null); > > + DefaultManagerFactory dmf = new DefaultManagerFactory(); > > + cm = dmf.accept(jd); > > + return cm.getConnection(); > > + } catch (SQLException e) { > > + LOG.error("Failed to create a connection to the > > Metastore"); > > + return null; > > + } > > + } > > + > > + private SqoopOptions getSqoopOptions() { > > + SqoopOptions options = new SqoopOptions(); > > + options.setConnectString(metaConnectString); > > + options.setUsername(metaUser); > > + options.setPassword(metaPass); > > + return options; > > + } > > + > > + @After > > + public void tearDown() { > > + super.tearDown(); > > + > > + try { > > + cm.close(); > > + } catch (SQLException e) { > > + LOG.error("Failed to close ConnManager"); > > + } > > + > > + } > > + > > + private String metaConnectString; > > + private String metaUser; > > + private String metaPass; > > + > > + > > + public JobToolTest(String metaConnectString, String metaUser, > > String metaPass) { > > + this.metaConnectString = metaConnectString; > > + this.metaUser = metaUser; > > + this.metaPass = metaPass; > > + } > > + > > + protected String[] getCreateJob(String metaConnectString, String > > metaUser, String metaPass) { > > + ArrayList<String> args = new ArrayList<String>(); > > + CommonArgs.addHadoopFlags(args); > > + args.add("--create"); > > + args.add("testJob"); > > + args.add("--meta-connect"); > > + args.add(metaConnectString); > > + args.add("--meta-username"); > > + args.add(metaUser); > > + args.add("--meta-password"); > > + args.add(metaPass); > > + args.add("--"); > > + args.add("list-tables"); > > + args.add("--connect"); > > + args.add(getConnectString()); > > + > > + return args.toArray(new String[0]); > > + } > > + > > + protected String[] getExecJob(String metaConnectString, String > > metaUser, String metaPass) { > > + ArrayList<String> args = new ArrayList<String>(); > > --- End diff -- > > > > Use superinterface instead of concrete implementation. > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > > with INFRA. > > --- > > > -- Szabolcs Vasas Software Engineer <http://www.cloudera.com>
