Github user szvasas commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/38#discussion_r130807571
  
    --- Diff: src/java/org/apache/sqoop/manager/CubridManager.java ---
    @@ -44,7 +44,7 @@
     
       // driver class to ensure is loaded when making db connection.
       private static final String DRIVER_CLASS =
    --- End diff --
    
    I think we could eliminate the DRIVER_CLASS constants from the managers and 
use JdbcDrivers enum directly in the constructors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to