-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 11:48 a.m.)
Review request for Sqoop.
Changes
-------
Updated based on review feedback.
Bugs: SQOOP-3224
https://issues.apache.org/jira/browse/SQOOP-3224
Repository: sqoop-trunk
Description
-------
Added --transfermode {ascii|binary} to support FTP transfer mode switching.
Diffs (updated)
-----
src/java/org/apache/sqoop/SqoopOptions.java 587d4e1d
src/java/org/apache/sqoop/mapreduce/BinaryKeyOutputFormat.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java dc49282e
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java
ea54b07f
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java
PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java
PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java
1f78384b
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java
f222dc8f
src/java/org/apache/sqoop/tool/MainframeImportTool.java 0cb91dbc
src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java
PRE-CREATION
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java
06141549
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/7/
Changes: https://reviews.apache.org/r/62492/diff/6-7/
Testing
-------
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh