----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62492/ -----------------------------------------------------------
(Updated Dec. 19, 2017, 12:30 p.m.) Review request for Sqoop. Changes ------- Feedback from review Bugs: SQOOP-3224 https://issues.apache.org/jira/browse/SQOOP-3224 Repository: sqoop-trunk Description ------- Added --transfermode {ascii|binary} to support FTP transfer mode switching. Diffs (updated) ----- src/java/org/apache/sqoop/SqoopOptions.java d5fdfba1 src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java dc49282e src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21 src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java ea54b07f src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java PRE-CREATION src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java PRE-CREATION src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java 1f78384b src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java f222dc8f src/java/org/apache/sqoop/tool/MainframeImportTool.java 0cb91dbc src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java PRE-CREATION src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java 06141549 src/test/org/apache/sqoop/tool/TestMainframeImportTool.java d51e33e5 src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194 Diff: https://reviews.apache.org/r/62492/diff/8/ Changes: https://reviews.apache.org/r/62492/diff/7-8/ Testing ------- Unit tests. Functional testing on mainframe. Thanks, Chris Teoh