-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62492/
-----------------------------------------------------------
(Updated May 30, 2018, 5:57 a.m.)
Review request for Sqoop.
Changes
-------
Fixed a critical bug that appeared as part of refactoring. Known tested working
version with a real mainframe.
Bugs: SQOOP-3224
https://issues.apache.org/jira/browse/SQOOP-3224
Repository: sqoop-trunk
Description
-------
Added --as-binaryfile and --buffersize to support FTP transfer mode switching.
Diffs (updated)
-----
src/java/org/apache/sqoop/SqoopOptions.java d9984af3
src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java a5962ba4
src/java/org/apache/sqoop/mapreduce/KeyRecordWriters.java PRE-CREATION
src/java/org/apache/sqoop/mapreduce/RawKeyTextOutputFormat.java fec34f21
src/java/org/apache/sqoop/mapreduce/mainframe/AbstractMainframeDatasetImportMapper.java
PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeConfiguration.java
ea54b07f
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryImportMapper.java
PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetBinaryRecord.java
PRE-CREATION
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetFTPRecordReader.java
1f78384b
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeDatasetImportMapper.java
0b7b5b85
src/java/org/apache/sqoop/mapreduce/mainframe/MainframeImportJob.java
7e975c7b
src/java/org/apache/sqoop/tool/BaseSqoopTool.java 783651a4
src/java/org/apache/sqoop/tool/ImportTool.java ee79d8b7
src/java/org/apache/sqoop/tool/MainframeImportTool.java 8883301d
src/java/org/apache/sqoop/util/MainframeFTPClientUtils.java 95bc0ecb
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetBinaryRecord.java
PRE-CREATION
src/test/org/apache/sqoop/mapreduce/mainframe/TestMainframeDatasetFTPRecordReader.java
3547294f
src/test/org/apache/sqoop/tool/TestMainframeImportTool.java 0b0c6c34
src/test/org/apache/sqoop/util/TestMainframeFTPClientUtils.java 90a85194
Diff: https://reviews.apache.org/r/62492/diff/12/
Changes: https://reviews.apache.org/r/62492/diff/11-12/
Testing
-------
Unit tests.
Functional testing on mainframe.
Thanks,
Chris Teoh
