Github user maugly24 commented on a diff in the pull request:
https://github.com/apache/sqoop/pull/60#discussion_r238013139
--- Diff:
src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
---
@@ -65,4 +66,21 @@
public String toString() {
return getClass().getSimpleName();
}
+
+ @Override
+ public Object[] getExpectedResultsForHive() {
--- End diff --
Hi @fszabo2 ,
If that's the case:
Could you please at least add some information about the intention behind
the values (A.K.A. explanatory comments by Uncle Bob), b/c right now for
example if this test would fail I would not have much clue about what values do
we have here, and why.
I'm thinking about something like:
this value is an int, XXX precision, so it should be YYYYY in Parquet/Hive
or something like
this value represents the biggest the longest possible values stored as
type ZZZ, thus it contains N digits, and should be KKKK in Hive.
Could we add these information, thus put these "Magic numbers" into a
context?
---
