[GitHub] sqoop pull request #60: SQOOP-3396: Add parquet numeric support for Parquet ...

[fszabo2]

Github user fszabo2 commented on a diff in the pull request:

    https://github.com/apache/sqoop/pull/60#discussion_r238251323
  
    --- Diff: 
src/test/org/apache/sqoop/importjob/configuration/MysqlImportJobTestConfiguration.java
 ---
    @@ -65,4 +66,21 @@
       public String toString() {
         return getClass().getSimpleName();
       }
    +
    +  @Override
    +  public Object[] getExpectedResultsForHive() {
    --- End diff --
    
    Fair point!
    
    I added a couple of comments, hope it clarifies the magic numbers.


---