Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/218#discussion_r18249411
--- Diff: storm-core/src/jvm/backtype/storm/spout/ShellSpout.java ---
@@ -152,8 +152,9 @@ private void querySubprocess() {
}
}
} catch (Exception e) {
- String processInfo = _process.getProcessInfoString() +
_process.getProcessTerminationInfoString();
- throw new RuntimeException(processInfo, e);
+ LOG.error("Halting process: ShellSpout died.", e);
--- End diff --
I think we should change
[ShellProcess#getErrorsStream](https://github.com/apache/storm/blob/24b5eefb1553ae37951807502a433f24d3e95ec1/storm-core/src/jvm/backtype/storm/utils/ShellProcess.java#L135-L145)
so that it checks that there is actually something to read.
This would fix a couple of other places where a hang looks possible:
*
https://github.com/apache/storm/blob/24b5eefb1553ae37951807502a433f24d3e95ec1/storm-core/src/jvm/backtype/storm/utils/ShellProcess.java#L68
*
https://github.com/apache/storm/blob/24b5eefb1553ae37951807502a433f24d3e95ec1/storm-core/src/jvm/backtype/storm/utils/ShellProcess.java#L70
*
https://github.com/apache/storm/blob/24b5eefb1553ae37951807502a433f24d3e95ec1/storm-core/src/jvm/backtype/storm/utils/ShellProcess.java#L101
ShellProcess#logErrorStream [does
this](https://github.com/apache/storm/blob/24b5eefb1553ae37951807502a433f24d3e95ec1/storm-core/src/jvm/backtype/storm/utils/ShellProcess.java#L123-L133).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
