Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/305#issuecomment-61269957
  
    If we're narrowing issue to just handle parent process's Exception hang, 
looks good to me.
    (We can make it better with extracting logic that reads from stderr to 
method, since it's duplicated from logErrorStream() and getErrorsString(). )
    
    This could be off-topic, but is there no chance to occur that subprocess 
writes stderr for some reason but parent process runs well without Exception? 
If it can possible, is parent process responsible to read stderr and do 
something (like logging, raise Exception, etc.)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to