[ 
https://issues.apache.org/jira/browse/STORM-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14185475#comment-14185475
 ] 

ASF GitHub Bot commented on STORM-456:
--------------------------------------

Github user Parth-Brahmbhatt commented on the pull request:

    https://github.com/apache/storm/pull/303#issuecomment-60635672
  
    search and replace is not a good solution, this seems to be another 
encoding decoding issue. I tested locally and from the initial investigation it 
feels like we have out of sync encoding and decoding schemes. 
    
    word count -> encoded by -> 
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/util.clj#L808
 -> results in word+count.
    
    however the ring gives us decoded id at 
https://github.com/apache/storm/blob/master/storm-core/src/clj/backtype/storm/ui/core.clj#L852
 which does not transalte "word+count" to "word count". 
    
    We need to ensure our encoding and decoding is done with the same scheme.


> Storm UI: cannot navigate to topology page when name contains spaces
> --------------------------------------------------------------------
>
>                 Key: STORM-456
>                 URL: https://issues.apache.org/jira/browse/STORM-456
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.1-incubating
>         Environment: storm version: 0.9.1.2.1.2.0-402
> Firefox ESR 17.0.9 on RHEL
>            Reporter: Steven Magana-Zook
>            Priority: Trivial
>
> 1. Create a Java class that makes your topology
> 2. Submit the topology with a name that contains spaces: 
> StormSubmitter.submitTopology("I Dont Want to Use Underscores", conf, 
> builder.createTopology());
> 3. Submit the jar to storm: storm jar yourUberJar your.topology.class.name
> 4. Open Storm UI in your browser
> 5. Click the link for the submitted topology under "Topology Summary"
> Result: Page refreshes but does not show the topology page
> Expected Result: clicking the link should take you to the topology screen 
> like it does for topologies whose names do not contain spaces OR an error 
> should be returned if a user submits a topology whose names contains spaces 
> and this is not supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to