[ 
https://issues.apache.org/jira/browse/STORM-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14196321#comment-14196321
 ] 

ASF GitHub Bot commented on STORM-456:
--------------------------------------

Github user harshach commented on the pull request:

    https://github.com/apache/storm/pull/303#issuecomment-61668317
  
    @NareshKosgi  I am -1 on current PR. Please look at the @Parth-Brahmbhatt  
suggested approach.
    Also lets not modify the existing examples to test it. It will be great if 
you can add unit tests to check if the different topology names are valid or 
not. Thanks.
    
    @clockfly special characters seems to have no issue. Please check the 
attached image. I was able to submit ./bin/storm jar 
examples/storm-starter/storm-starter-topologies-0.9.3-rc2-SNAPSHOT.jar 
storm.starter.WordCountTopology "word#&count)(" 
    
![image](https://cloud.githubusercontent.com/assets/38649/4903389/0a1d1cfa-6440-11e4-972b-1618dc1d1193.png)



> Storm UI: cannot navigate to topology page when name contains spaces
> --------------------------------------------------------------------
>
>                 Key: STORM-456
>                 URL: https://issues.apache.org/jira/browse/STORM-456
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.9.1-incubating
>         Environment: storm version: 0.9.1.2.1.2.0-402
> Firefox ESR 17.0.9 on RHEL
>            Reporter: Steven Magana-Zook
>            Priority: Trivial
>
> 1. Create a Java class that makes your topology
> 2. Submit the topology with a name that contains spaces: 
> StormSubmitter.submitTopology("I Dont Want to Use Underscores", conf, 
> builder.createTopology());
> 3. Submit the jar to storm: storm jar yourUberJar your.topology.class.name
> 4. Open Storm UI in your browser
> 5. Click the link for the submitted topology under "Topology Summary"
> Result: Page refreshes but does not show the topology page
> Expected Result: clicking the link should take you to the topology screen 
> like it does for topologies whose names do not contain spaces OR an error 
> should be returned if a user submits a topology whose names contains spaces 
> and this is not supported.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to