Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/365#issuecomment-70685389
My biggest comment is that there are some TODOs in the code that look like
they have already been addressed and should be deleted. I would like to see
some unit tests at some point too, but the integration test/examples seem like
a good start. I am +1 for merging this in, although I would like others to
take a look at the code as well.
The committer question for @dashengju and @HeartSaVioR would need to be
discussed on the private list, but if it helps to get this in, I am willing to
lend my name to support the code as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
