Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/365#issuecomment-70755347
@Parth-Brahmbhatt
Thanks for review!
First of all, let's start about abstract bolt.
https://github.com/apache/storm/pull/365#issuecomment-68332013
You can see the matrix I've commented.
Redis provides so many data types so we need to decide what data types we
support or not.
I thought JedisCommands is easy and convenient enough to use so users would
no problem to extend abstract bolt and make his/her own bolt.
But I'm also thinking it is really better for users to force making bolt,
instead of providing some simple bolts. It could be already inconvenient to use
in point of users' view.
@revans2 @dashengju How do you think about?
Btw, persist/lookup bolts for some datatypes can be added at any time.
Also, changing mapper to support normal bolt and trident seems great.
We can check it now, and provide some bolts based on it if it works
smoothly.
Thanks for your help!
Then let's talk about README.md.
Describing usage of AbstractBolt to README.md is already done, please see
AbstractRedisBolt usage.
I agree we should remove description related to SharededJedis. I'll take
care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
