Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/401#discussion_r23801424
--- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
@@ -349,6 +350,20 @@
(keys keepers))
(zipmap (vals new-worker-ids) (keys new-worker-ids))
))
+
+ ;; check storm topology code dir exists before launching workers
+ (doseq [[port assignment] reassign-executors]
+ (let [storm-cluster-state (:storm-cluster-state supervisor)
+ downloaded-storm-ids (set (read-downloaded-storm-ids conf))
+ storm-id (:storm-id assignment)
+ assignment-info (.assignment-info-with-version
storm-cluster-state storm-id nil)
--- End diff --
This is going to cause a large load on zookeeper. There is a reason we
have the cache for the assignment info, and we only download it when it has
changed. We really should use the cache here if we can.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
