Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/401#discussion_r23803166
  
    --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj ---
    @@ -349,6 +350,20 @@
                             (keys keepers))
                (zipmap (vals new-worker-ids) (keys new-worker-ids))
                ))
    +
    +    ;; check storm topology code dir exists before launching workers
    +    (doseq [[port assignment] reassign-executors]
    +      (let [storm-cluster-state (:storm-cluster-state supervisor)
    +            downloaded-storm-ids (set (read-downloaded-storm-ids conf))
    +            storm-id (:storm-id assignment)
    +            assignment-info (.assignment-info-with-version 
storm-cluster-state storm-id nil)
    --- End diff --
    
    Yes.  We could replace it with ```@(:assignment-versions supervisor)``` and 
presumably get the same result without hitting zookeeper.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to