[
https://issues.apache.org/jira/browse/STORM-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396181#comment-14396181
]
ASF GitHub Bot commented on STORM-753:
--------------------------------------
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/504
[STORM-753] Improve RedisStateQuerier to convert List<Values> from Redis
value
Please see https://issues.apache.org/jira/browse/STORM-753 for more details.
Applied some refactoring to reduce code duplication, and some optimization
regarding round-trip / Pipeline.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-753
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/504.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #504
----
commit 7fec9a1f4b9887897c9c7d0f3f80433fa34f18c0
Author: Jungtaek Lim <[email protected]>
Date: 2015-04-05T00:38:54Z
Improve RedisStateQuerier to convert List<Values> from Redis value
* Reuse RedisStoreMapper / RedisLookupMapper
** RedisState*Querier / RedisState*Updater
commit 8fd1f4b193b5d81b3036726268da39380e2b3b61
Author: Jungtaek Lim <[email protected]>
Date: 2015-04-05T03:21:57Z
Redis*StateQuerier / Redis*StateUpdater now support HASH type
* use Pipeline when available to gain performance
* extract abstract classes to reduce code duplication
** AbstractRedisStateQuerier, AbstractRedisStateUpdater
commit b9c0329bd182333f0af237e661e88958d7157520
Author: Jungtaek Lim <[email protected]>
Date: 2015-04-05T09:55:03Z
Extract abstract classes to reduce code duplication (Redis*MapState)
----
> [storm-redis] Let Redis*StateUpdater to have additional mapper - converting
> Redis key/value to Storm Values
> -----------------------------------------------------------------------------------------------------------
>
> Key: STORM-753
> URL: https://issues.apache.org/jira/browse/STORM-753
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> https://issues.apache.org/jira/browse/STORM-723?focusedCommentId=14381626&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14381626
> Currently Redis*StateUpdater use key prefix to let users customize key name.
> Since it's less powerful, how about having 2 mappers which one is for
> converting tuple to key/value, and another one is for converting value from
> Redis to Storm Values?
> You can refer
> https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
