[
https://issues.apache.org/jira/browse/STORM-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567518#comment-14567518
]
ASF GitHub Bot commented on STORM-753:
--------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/504#discussion_r31442886
--- Diff: external/storm-redis/README.md ---
@@ -184,7 +184,8 @@ RedisState
JedisPoolConfig poolConfig = new JedisPoolConfig.Builder()
.setHost(redisHost).setPort(redisPort)
.build();
- TridentTupleMapper tupleMapper = new WordCountTupleMapper();
+ RedisStoreMapper storeMapper = new WordCountStoreMapper();
--- End diff --
storeMapper does not appear to be used later on, and should probably be
removed.
> [storm-redis] Let Redis*StateUpdater to have additional mapper - converting
> Redis key/value to Storm Values
> -----------------------------------------------------------------------------------------------------------
>
> Key: STORM-753
> URL: https://issues.apache.org/jira/browse/STORM-753
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0, 0.11.0
> Reporter: Jungtaek Lim
> Assignee: Jungtaek Lim
>
> https://issues.apache.org/jira/browse/STORM-723?focusedCommentId=14381626&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14381626
> Currently Redis*StateUpdater use key prefix to let users customize key name.
> Since it's less powerful, how about having 2 mappers which one is for
> converting tuple to key/value, and another one is for converting value from
> Redis to Storm Values?
> You can refer
> https://github.com/apache/storm/blob/master/external/storm-hbase/src/main/java/org/apache/storm/hbase/trident/state/HBaseState.java.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
