Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/499#discussion_r27830636
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -526,7 +526,8 @@
out-tuple
overflow-buffer)
))
- (if rooted?
+ (if (and rooted?
+ (seq out-ids)) ;; not
empty
--- End diff --
`(not (.isEmpty out-ids))` might be better.
`seq` is going to create a new ISeq and do copying every execution of this
loop.
Probably not a big deal, but it's easy to make better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
