Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/499#discussion_r27892323
--- Diff: storm-core/src/clj/backtype/storm/daemon/executor.clj ---
@@ -526,7 +526,8 @@
out-tuple
overflow-buffer)
))
- (if rooted?
+ (if (and rooted?
+ (seq out-ids)) ;; not
empty
--- End diff --
Yes, this is more work than we need. It creates an
[IteratorSeq](https://github.com/clojure/clojure/blob/d6baf6e1fb6e2b9ab3e3a459de5ab1d4381938aa/src/jvm/clojure/lang/IteratorSeq.java#L32-L37)
each time, since the input is an ArrayList. I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
