GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/521
[STORM-737] Check task->node+port with read lock to prevent sending to
closed connection
It's based on Nathan's comment, please refer to
https://github.com/apache/storm/pull/349#issuecomment-87778672
https://github.com/apache/storm/commit/861a92eab8740cfc0f83ac4d7ade9a2ab04a8b9b
seems to make a regression.
But it also introduces optimizations of sending, it shouldn't be discarded.
I changed send logic to let TransferDrainer matches task to node+port so
then we can still enjoy optimization of sending logic.
I'm still not familiar with clojure so please review and comment if it can
be optimized.
Thanks!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-737
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #521
----
commit a1d7b3eb343f304565fe24fb7e0151bfbcb3824e
Author: Jungtaek Lim <[email protected]>
Date: 2015-04-13T22:16:37Z
While sending tuple, check task->node+port with read lock
* we can ensure task->node+port is safe within read lock
** refer write lock inside of mk-refresh-connections
* Let TransferDrainer matches task to node+port
** So then we can still enjoy optimization of sending logic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
