Github user d2r commented on the pull request:
https://github.com/apache/storm/pull/521#issuecomment-101382574
@HeartSaVioR
Thanks for taking a look. Well, I was trying to follow his comments. :)
I noticed though, that the line in my `let` binding
```Clojure
valid-node+ports (vals task->node+port)
```
maybe should have been
```Clojure
valid-node+ports (vals @task->node+port)
```
with the `@`.
`task->node+port` is actually an atom, however, so if we dereference it
within the read-lock there, we should have the accurate task assignment before
we add anything to the queue to be sent. I believe this addresses the concern
you cited from @nathanmarz. The other change was to encapsulate the separate
TransferDrainer#add, since it does not need to be a separate public method.
So, @HeartSaVioR, since we have both looked at my branch already, do you
want to take my changes into your branch and continue the discussion from
there? It seems like a smaller set of changes to begin with, and maybe it
would be easier going forward?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
