Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/521#discussion_r30197344
--- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java ---
@@ -26,10 +26,10 @@
public class TransferDrainer {
- private HashMap<String, ArrayList<ArrayList<TaskMessage>>> bundles = new
HashMap();
+ private HashMap<Integer, ArrayList<ArrayList<TaskMessage>>> bundles =
new HashMap();
- public void add(HashMap<String, ArrayList<TaskMessage>>
workerTupleSetMap) {
- for (String key : workerTupleSetMap.keySet()) {
+ public void add(HashMap<Integer, ArrayList<TaskMessage>>
taskTupleSetMap) {
--- End diff --
@d2r
Yes, we don't need this since we're adding tuples and sending it
immediately.
I'll make it private and add parameter to send. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---