GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/557
[STORM-737] Check task->node+port with read lock to prevent sending to
closed connection
* we can ensure task->node+port is safe within read lock
** refer write lock inside of mk-refresh-connections
* don't group messages from transfer-fn cause we'll match task->node+port
later
* Let TransferDrainer groups message to node+port by referring task id
** So then we can still enjoy optimization of sending logic
Actually it's another approach from #521, but this changeset is cleaner so
I'd like to move on this PR.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-737-2nd-appraoch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/557.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #557
----
commit 6ef2f11e9eade772c8ae67a6410d537871739938
Author: Jungtaek Lim <[email protected]>
Date: 2015-05-13T22:50:45Z
While sending tuple, check task->node+port with read lock
* we can ensure task->node+port is safe within read lock
** refer write lock inside of mk-refresh-connections
* don't group messages from transfer-fn cause we'll match task->node+port
later
* Let TransferDrainer groups message to node+port by referring task id
** So then we can still enjoy optimization of sending logic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
