Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/521#issuecomment-106038982
  
    Tested with https://github.com/yahoo/storm-perf-test with the following 
arguments:
    ```
    --ack --bolt 4 --name test -l 1 -n 1 --workers 4 --spout 3 --testTimeSec 900
    -c topology.max.spout.pending=1092 --messageSize 10
    ```
    
    OK, I found both the data-rate and the latency are improved with this patch 
in my tests:
    
    master at 512d3def:
    Throughput in MB/s:
      max: 0.1519711812
      99:  0.1510783919
      90:  0.1276066783
      50:  0.1100190481
      min: 0.07258733114
    Complete Latency/10m: 265ms
    
    This PR 85c5096e merged to master at 512d3def:
    Throughput in MB/s:
      max: 0.1760864258
      99:  0.1707911174
      90:  0.1550458272
      50:  0.1419607798
      min: 0.1128451029
    Complete Latency/10m: 204ms
    
    I am also fine with the changes.
    
    +1
    
    Thank you for your patience, @HeartSaVioR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to