[
https://issues.apache.org/jira/browse/STORM-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560013#comment-14560013
]
ASF GitHub Bot commented on STORM-821:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31086911
--- Diff: external/storm-jdbc/README.md ---
@@ -1,10 +1,37 @@
#Storm JDBC
Storm/Trident integration for JDBC. This package includes the core bolts
and trident states that allows a storm topology
to either insert storm tuples in a database table or to execute select
queries against a database and enrich tuples
-in a storm topology. This code uses HikariCP for connection pooling. See
http://brettwooldridge.github.io/HikariCP.
+in a storm topology.
## Inserting into a database.
The bolt and trident state included in this package for inserting data
into a database tables are tied to a single table.
+
+### ConnectionProvider
+An interface that should be implemented by different connection pooling
mechanism `org.apache.storm.jdbc.common.ConnectionPrvoider`
--- End diff --
There's a typo, ConnectionProvioder -> ConnectionProvider.
> storm-jdbc create a connection provider interface to decouple from hikariCP
> being the only connection pool implementation that can be used.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-821
> URL: https://issues.apache.org/jira/browse/STORM-821
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Priority: Minor
> Fix For: 0.10.0
>
>
> The current implementation of storm-jdbc is couple with HikariCP
> configuration. We propose to remove this coupling by introducing a
> connectionProvider interface with a default HikariCP implementation. This
> will allow users to do their own connection pool management or chose a
> different connection pooling library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
