[
https://issues.apache.org/jira/browse/STORM-821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560031#comment-14560031
]
ASF GitHub Bot commented on STORM-821:
--------------------------------------
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/556#discussion_r31087567
--- Diff: external/storm-jdbc/README.md ---
@@ -29,13 +57,21 @@ The default is set to value of
topology.message.timeout.secs and a value of -1 w
You should set the query timeout value to be <=
topology.message.timeout.secs.
```java
-Config config = new Config();
-config.put("jdbc.conf", hikariConfigMap);
-JdbcInsertBolt userPersistanceBolt = new
JdbcInsertBolt("jdbc.conf",simpleJdbcMapper)
+Map hikariConfigMap = Maps.newHashMap();
--- End diff --
minor thing:
How about changing this line to
```
Map<String, String> hikariConfigMap = new HashMap<String, String>();
```
to remove dependency about Guava from example?
> storm-jdbc create a connection provider interface to decouple from hikariCP
> being the only connection pool implementation that can be used.
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-821
> URL: https://issues.apache.org/jira/browse/STORM-821
> Project: Apache Storm
> Issue Type: Improvement
> Affects Versions: 0.10.0
> Reporter: Parth Brahmbhatt
> Assignee: Parth Brahmbhatt
> Priority: Minor
> Fix For: 0.10.0
>
>
> The current implementation of storm-jdbc is couple with HikariCP
> configuration. We propose to remove this coupling by introducing a
> connectionProvider interface with a default HikariCP implementation. This
> will allow users to do their own connection pool management or chose a
> different connection pooling library.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
