Github user zhuoliu commented on a diff in the pull request:

    https://github.com/apache/storm/pull/572#discussion_r32569256
  
    --- Diff: external/storm-kafka/src/test/storm/kafka/KafkaUtilsTest.java ---
    @@ -168,7 +168,7 @@ public void 
generateTuplesWithValueSchemeAndKeyValueMessage() {
         }
     
         private ByteBufferMessageSet getLastMessage() {
    -        long offsetOfLastMessage = KafkaUtils.getOffset(simpleConsumer, 
config.topic, 0, OffsetRequest.LatestTime()) - 1;
    +        long offsetOfLastMessage = KafkaUtils.getOffset(simpleConsumer, 
config.topic, 0, OffsetRequest.LatestTime());
    --- End diff --
    
    To address this concern, I just updated the producer in KafkaUtilsTest with 
new kafka Producer API, and use "send().get()" to do synchronous sending. Then 
the offset uncertainty can be fixed and we no longer need to change that offset 
line in the test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to