Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/storm/pull/572#discussion_r33256376
  
    --- Diff: external/storm-kafka/src/jvm/storm/kafka/bolt/KafkaBolt.java ---
    @@ -53,10 +55,13 @@
         public static final String TOPIC = "topic";
         public static final String KAFKA_BROKER_PROPERTIES = 
"kafka.broker.properties";
     
    -    private Producer<K, V> producer;
    +    private KafkaProducer<K, V> producer;
         private OutputCollector collector;
         private TupleToKafkaMapper<K,V> mapper;
         private KafkaTopicSelector topicSelector;
    +    /* With default setting for fireAndForget and async, the callback is 
called when sending succeed */
    +    private boolean fireAndForget = false;  /* by setting as true, each 
send immediately gets acked by collector */
    --- End diff --
    
    lets clarify this comment saying it doesn't wait at all for kafka to ack.  
ack setting doesn't matter if this is used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to