[ https://issues.apache.org/jira/browse/STORM-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598525#comment-14598525 ]
ASF GitHub Bot commented on STORM-871: -------------------------------------- Github user HeartSaVioR commented on a diff in the pull request: https://github.com/apache/storm/pull/602#discussion_r33101920 --- Diff: storm-core/test/clj/backtype/storm/multilang_test.clj --- @@ -45,9 +45,9 @@ {"2" (thrift/mk-shell-bolt-spec {"1" :shuffle} [executor (str "tester_bolt." file-extension)] ["word"] :parallelism-hint 1)})] (submit-local-topology nimbus "test" - {TOPOLOGY-WORKERS 20 TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 TOPOLOGY-DEBUG true} + {TOPOLOGY-WORKERS 20 TOPOLOGY-MESSAGE-TIMEOUT-SECS 3 TOPOLOGY-DEBUG true SUPERVISOR-WORKER-TIMEOUT-SECS 3} topology) - (Thread/sleep 10000) + (Thread/sleep 20000) --- End diff -- Adjust option regarding subprocess heartbeat and make test longer for improving test more accurate. > Change multilang heartbeat mechanism to multi-threading of subprocess > --------------------------------------------------------------------- > > Key: STORM-871 > URL: https://issues.apache.org/jira/browse/STORM-871 > Project: Apache Storm > Issue Type: Improvement > Reporter: Jungtaek Lim > > Having design constraint of multilang heartbeat, some issues are raised at > the moment. > (https://issues.apache.org/jira/browse/STORM-738 is a kind of reporting) > I'm trying to add workarounds > (https://issues.apache.org/jira/browse/STORM-742 and so on), but if we can > get rid of design constraint it would be really great. > Maybe we can use pid file of subprocess (subprocess write it from sendpid()) > to check subprocess heartbeat from ShellSpout / ShellBolt. > Letting subprocess launch new thread which writes pid file periodically, to > make sure "modified time" of file is periodically up to date. (It is just an > idea, and it should be validated.) -- This message was sent by Atlassian JIRA (v6.3.4#6332)