[ 
https://issues.apache.org/jira/browse/STORM-871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628039#comment-14628039
 ] 

ASF GitHub Bot commented on STORM-871:
--------------------------------------

Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/602#issuecomment-121612188
  
    After discussed with @dan-blanchard , I gave up introducing new multilang 
heartbeat mechanism.
    It would be new requirement to storm multilang libraries, which library 
developers already struggled with current heartbeat mechanism.
    Above all, I can't think about overcoming GIL.
    
    I'll close this issue, but to stick with current mechanism STORM-742 should 
be merged.


> Change multilang heartbeat mechanism to multi-threading of subprocess
> ---------------------------------------------------------------------
>
>                 Key: STORM-871
>                 URL: https://issues.apache.org/jira/browse/STORM-871
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Jungtaek Lim
>            Assignee: Jungtaek Lim
>
> Having design constraint of multilang heartbeat, some issues are raised at 
> the moment.
> (https://issues.apache.org/jira/browse/STORM-738 is a kind of reporting)
> I'm trying to add workarounds 
> (https://issues.apache.org/jira/browse/STORM-742 and so on), but if we can 
> get rid of design constraint it would be really great.
> Maybe we can use pid file of subprocess (subprocess write it from sendpid()) 
> to check subprocess heartbeat from ShellSpout / ShellBolt.
> Letting subprocess launch new thread which writes pid file periodically, to 
> make sure "modified time" of file is periodically up to date. (It is just an 
> idea, and it should be validated.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to