[
https://issues.apache.org/jira/browse/STORM-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649599#comment-14649599
]
ASF GitHub Bot commented on STORM-904:
--------------------------------------
GitHub user priyank5485 opened a pull request:
https://github.com/apache/storm/pull/662
STORM-904: Move bin/storm command line to java.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/priyank5485/storm storm-904
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/662.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #662
----
commit 193f59e027a8ab95d72c8e386d66f0b90f9b86f9
Author: Priyank <[email protected]>
Date: 2015-07-17T23:45:13Z
Remove python and add a java class to support storm cli.
Add a java class that encapsulates storm cli functionality currently
coded in two different places. storm, storm.py for bash and storm.cmd
for windows. Now both storm and storm.cmd will call the java class
eliminating python code and putting all the code in one place for bash
and windows respectively.
commit 793781cfd55c56f7184910fd744341351f6cc4bf
Author: Priyank <[email protected]>
Date: 2015-07-20T23:04:48Z
Add apace commons cli library for command line parsing
commit a425fc50ab9b518337d0c095ae80e9d78221e3fd
Author: Priyank <[email protected]>
Date: 2015-07-21T17:44:30Z
Adding version for dependency in pom file.
commit 5a4ec36ac17af69297dfc73aaa682b8e43edf5de
Author: Priyank <[email protected]>
Date: 2015-07-21T21:23:54Z
Sample code to test for apache commons cli.
commit 1a8240a558516110a5c14d3a4bb0b177ab76090b
Author: Priyank <[email protected]>
Date: 2015-07-22T23:40:40Z
Removing apache commons cli, renaming and some intiialization code.
commit b69e295e81216e992187737cc069ff66d2e74687
Author: Priyank <[email protected]>
Date: 2015-07-23T10:14:48Z
Some redesigning/refactoring.
commit 8c2fbeadbf699b5b286479649d133623c92bc85c
Author: Priyank <[email protected]>
Date: 2015-07-23T21:49:43Z
Add printUsage mainly.
commit 74f45c7c9d6ae813635c91ba14fdb1cd3dd24c74
Author: Priyank <[email protected]>
Date: 2015-07-24T18:49:15Z
Call storm command methods using reflection.
commit 10ba25f8c81e2fdc34f4ae3e0e2cdf9ecd142a4a
Author: Priyank <[email protected]>
Date: 2015-07-24T19:25:01Z
Add method boxes without code for other storm commands.
commit fb2022db8dda7a5183ee5a2cc64a7ef035006c80
Author: Priyank <[email protected]>
Date: 2015-07-27T17:59:20Z
Initial executeStorm method creating a new process.
Need to test storm daemons if they can be killed using shutdown hooks.
commit 493b0dfeb7be2daa0a54e7dec2f3f716d0af0e26
Author: Priyank <[email protected]>
Date: 2015-07-29T07:02:49Z
Ship some more code over from python.
commit 3082d4f5ea2d66babe232e5ff49506b322385473
Author: Priyank <[email protected]>
Date: 2015-07-29T18:49:57Z
Fix an exception which failed to start the nimbus command.
commit c616068d90dd47fa61fbb670c2853805d7ccb324
Author: Priyank <[email protected]>
Date: 2015-07-29T21:53:27Z
Use exec to replace current process rather than creating a new one.
commit 06f4dcc17d8dcf3c81094557ed97ff117d6410ed
Author: Priyank <[email protected]>
Date: 2015-07-30T08:37:08Z
Add some commented code.
commit da0ad60438841a1f874c115cef27190a59401f4f
Author: Priyank <[email protected]>
Date: 2015-07-30T15:45:52Z
Add nil check for strings returned from conclave
commit 0b242adf0bc261e9140c3587b3eedd2141e31718
Author: Priyank <[email protected]>
Date: 2015-07-30T19:04:35Z
Fix an issue with passing options to storm command,
commit 0bb15782c171d336be905d2f5143865e288a8239
Author: Priyank <[email protected]>
Date: 2015-07-31T00:37:07Z
STORM-904: Add shutdown hook thread to kill subprocess.
Does not work for kill -9. Need to debug.
----
> move storm bin commands to java and provide appropriate bindings for windows
> and linux
> --------------------------------------------------------------------------------------
>
> Key: STORM-904
> URL: https://issues.apache.org/jira/browse/STORM-904
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sriharsha Chintalapani
> Assignee: Priyank Shah
>
> Currently we have python and .cmd implementation for windows. This is
> becoming increasing difficult upkeep both versions. Lets make all the main
> code of starting daemons etc. to java and provider wrapper scripts in shell
> and batch for linux and windows respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
