[
https://issues.apache.org/jira/browse/STORM-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649624#comment-14649624
]
ASF GitHub Bot commented on STORM-904:
--------------------------------------
Github user priyank5485 commented on the pull request:
https://github.com/apache/storm/pull/662#issuecomment-126779134
This PR aims at factoring out the logic for storm command line client which
currently resides in two places. One in storm bash script and storm.py for Unix
and storm.cmd for Windows. Idea is to create a java program that will be called
from storm.cmd and storm bash script which will have all the logic from
storm.py and storm.cmd in one place. This will help us maintain the storm
client better since we will have only one file to change and in most cases only
the base class that both Windows and Unix classes inherit from. I have already
removed storm.py. I am working on finishing up the java file and also removing
the storm.cmd file. Just putting it out there to elicit response to this
approach from the community.
> move storm bin commands to java and provide appropriate bindings for windows
> and linux
> --------------------------------------------------------------------------------------
>
> Key: STORM-904
> URL: https://issues.apache.org/jira/browse/STORM-904
> Project: Apache Storm
> Issue Type: Bug
> Reporter: Sriharsha Chintalapani
> Assignee: Priyank Shah
>
> Currently we have python and .cmd implementation for windows. This is
> becoming increasing difficult upkeep both versions. Lets make all the main
> code of starting daemons etc. to java and provider wrapper scripts in shell
> and batch for linux and windows respectively.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
