[ https://issues.apache.org/jira/browse/STORM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695940#comment-14695940 ]
ASF GitHub Bot commented on STORM-976: -------------------------------------- Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/684#discussion_r37024792 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -661,8 +661,8 @@ storm-conf-file (System/getProperty "storm.conf.file") storm-log-dir (or (System/getProperty "storm.log.dir") (str storm-home file-path-separator "logs")) storm-conf (read-storm-config) - storm-log-conf-dir (storm-conf "storm.logback.conf.dir") - storm-logback-conf-dir (or storm-log-conf-dir (str storm-home file-path-separator "log4j2")) + storm-log-conf-dir (storm-conf "storm.log4j2.conf.dir") --- End diff -- Hey, there. I know you're just updating the existing code, but would you mind adding `"storm.log4j2.conf.dir"` to Config.java and removing the `storm-conf (read-storm-config)` binding? Both of those lines were added in #373 and went uncaught. Instead of reading from `storm-conf`, just read from `conf`. > Config storm.logback.conf.dir is specific to previous logging framework > ----------------------------------------------------------------------- > > Key: STORM-976 > URL: https://issues.apache.org/jira/browse/STORM-976 > Project: Apache Storm > Issue Type: Bug > Affects Versions: 0.10.0 > Reporter: Derek Dagit > Priority: Minor > Labels: Newbie > > Storm has migrated from logback to log4j2, so we should rename this config > and code that uses it. > https://github.com/apache/storm/blob/544e55cb8ab8878c4af500aab49bd35d4b69cd3e/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L664 -- This message was sent by Atlassian JIRA (v6.3.4#6332)