[ 
https://issues.apache.org/jira/browse/STORM-976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697483#comment-14697483
 ] 

ASF GitHub Bot commented on STORM-976:
--------------------------------------

Github user YvonneIronberg commented on a diff in the pull request:

    https://github.com/apache/storm/pull/684#discussion_r37103291
  
    --- Diff: storm-core/src/jvm/backtype/storm/Config.java ---
    @@ -145,6 +145,12 @@
         public static final String STORM_LOCAL_DIR = "storm.local.dir";
         public static final Object STORM_LOCAL_DIR_SCHEMA = String.class;
     
    +           /**
    +            * A directory that holds configuration files for log4j2.
    +            */
    +           public static final String STORM_LOG4J2_CONF_DIR = 
"storm.log4j2.conf.dir";
    +           public static final Object STORM_LOG4J2_CONF_DIR_SCHEMA = 
String.class;
    +
    --- End diff --
    
    Thanks. Done.


> Config storm.logback.conf.dir is specific to previous logging framework
> -----------------------------------------------------------------------
>
>                 Key: STORM-976
>                 URL: https://issues.apache.org/jira/browse/STORM-976
>             Project: Apache Storm
>          Issue Type: Bug
>    Affects Versions: 0.10.0
>            Reporter: Derek Dagit
>            Priority: Minor
>              Labels: Newbie
>
> Storm has migrated from logback to log4j2, so we should rename this config 
> and code that uses it.
> https://github.com/apache/storm/blob/544e55cb8ab8878c4af500aab49bd35d4b69cd3e/storm-core/src/clj/backtype/storm/daemon/supervisor.clj#L664



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to